Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary V8 flag #37671

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 9, 2021

I'm trying to remove the flag upstream.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 9, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 9, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 9, 2021

fast-track?

@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Mar 9, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 9, 2021

Landed in 5247dc0

@aduh95 aduh95 merged commit 5247dc0 into nodejs:master Mar 9, 2021
@aduh95 aduh95 deleted the weak-ref-harmony branch March 9, 2021 15:24
aduh95 added a commit to aduh95/node that referenced this pull request Mar 9, 2021
aduh95 added a commit to aduh95/node that referenced this pull request Mar 15, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: #37671
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: #37671
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants