Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add @marsonya as a triager #37667

Closed
wants to merge 2 commits into from
Closed

doc: add @marsonya as a triager #37667

wants to merge 2 commits into from

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Mar 9, 2021

I would like to apply for the role of a triager in this project.
My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator!

I hereby declare that I have read and understood the Code of Conduct and will adhere to that.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 9, 2021
@gireeshpunathil
Copy link
Member

LGTM. For the context, here is the documentation for triage process and triager role:
https://github.com/nodejs/node/blob/5421e15bdc6122420d90ec462c3622b57d59c9d6/doc/guides/contributing/issues.md#triaging-a-bug-report

@targos
Copy link
Member

targos commented Mar 9, 2021

@marsonya I suggest that you remove the "@" from your username in the commit message. If the commit lands as is, you will be notified by GitHub everytime it's cherry-picked or pushed somewhere.

@marsonya
Copy link
Member Author

marsonya commented Mar 9, 2021 •
edited
Loading

@marsonya I suggest that you remove the "@" from your username in the commit message. If the commit lands as is, you will be notified by GitHub everytime it's cherry-picked or pushed somewhere.

Thanks for the suggestion. I have made changes and removed the "@" from the commit message.

@gireeshpunathil
Copy link
Member

@marsonya - also pls follow the commit message guidelines documented here - namely:

  • first line starts with the name of a subsystem (in this case doc)
  • followed by : and the message title, not exceeding 50 columns
  • leve a blank line after that
  • next lines should wrap in 72 columns

@marsonya marsonya closed this Mar 9, 2021
@marsonya
doc: add marsonya as a triager
ee95681 
I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that.
@marsonya marsonya reopened this Mar 9, 2021
@marsonya
Copy link
Member Author

marsonya commented Mar 9, 2021

@marsonya - also pls follow the commit message guidelines documented here - namely:

  • first line starts with the name of a subsystem (in this case doc)
  • followed by : and the message title, not exceeding 50 columns
  • leve a blank line after that
  • next lines should wrap in 72 columns

Apologies for the mess. The commit message was a result of me amending the first commit to remove "@" from commit message. It's all fixed now.

mhdawson
mhdawson approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gireeshpunathil pushed a commit that referenced this pull request Mar 16, 2021
@marsonya @gireeshpunathil
doc: add marsonya as a triager
3bba40a 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@gireeshpunathil
Copy link
Member

landed in 3bba40a

@gireeshpunathil
Copy link
Member

sent invitation to @marsonya

@marsonya
Copy link
Member Author

sent invitation to @marsonya

received and accepted! thanks :)

danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya @danielleadams
doc: add marsonya as a triager
9fad821 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya @danielleadams
doc: add marsonya as a triager
89f3aa9 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
doc: add marsonya as a triager
6d7c7bc 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@VoltrexKeyva VoltrexKeyva mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marsonya @gireeshpunathil @targos @Trott @mhdawson @RaisinTen @PoojaDurgad @nodejs-github-bot