Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove FLAKY status for fixed test #37633

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 6, 2021

test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
@nodejs-github-bot
Copy link
Collaborator

@PoojaDurgad PoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2021
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

PR-URL: nodejs#37633
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 8, 2021

Landed in 5cea29b

@Trott Trott merged commit 5cea29b into nodejs:master Mar 8, 2021
@Trott Trott deleted the status-only branch March 8, 2021 17:38
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

PR-URL: #37633
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

PR-URL: #37633
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants