Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve error reporting in test-child-process-pipe-dataflow #37632

Merged
merged 1 commit into from
Mar 9, 2021
Merged

test: improve error reporting in test-child-process-pipe-dataflow #37632

merged 1 commit into from
Mar 9, 2021

Commits on Mar 9, 2021

  1. test: improve error reporting in test-child-process-pipe-dataflow 

    When the test fails, it usually ends up failing on the assertion that
`wc` did not find as many bytes as it expected. That may not be
helpful if it is caused by a failure earlier in the command
pipeline ( cat | grep | wc ). Move the byte check to
`process.on('exit')` so that other error handlers that report the
existence of errors run first.

Refs: nodejs#25988

PR-URL: nodejs#37632
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @Trott
    Trott committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    7f54dd4 View commit details
    Browse the repository at this point in the history