Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: apply sentence case to headers in doc/guides/contributing/pull-requests.md #37602

Merged
merged 1 commit into from
Mar 6, 2021
Merged

doc: apply sentence case to headers in doc/guides/contributing/pull-requests.md #37602

merged 1 commit into from
Mar 6, 2021

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Mar 4, 2021

changes as per doc styling guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 4, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
@jasnell
Copy link
Member

jasnell commented Mar 5, 2021

fast-track?

PR-URL: #37602
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Mar 6, 2021

Landed in 7c7b983

@Trott Trott merged commit 7c7b983 into nodejs:master Mar 6, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37602
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37602
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants