Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add error formatting support #37598

Merged
merged 1 commit into from
Mar 9, 2021
Merged

src: add error formatting support #37598

merged 1 commit into from
Mar 9, 2021
+52 −29

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Mar 4, 2021

This enables the use of format strings in our native error functions. It also includes some light usage in ModuleWrap.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 4, 2021
@devsnek devsnek force-pushed the better-native-errors branch from 79a1cce to db938cf Compare March 4, 2021 04:29
RaisinTen
RaisinTen reviewed Mar 4, 2021
View reviewed changes
src/node_errors.h Outdated Show resolved Hide resolved
@devsnek devsnek force-pushed the better-native-errors branch from db938cf to caaffe6 Compare March 5, 2021 17:10
@devsnek devsnek requested review from addaleax and RaisinTen March 5, 2021 17:11
@devsnek devsnek force-pushed the better-native-errors branch from caaffe6 to 21b4ee7 Compare March 5, 2021 17:28
addaleax
addaleax approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36495/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36512/

@targos
Copy link
Member

targos commented Mar 6, 2021

Does this need a documentation update (for the error code) ?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36523/

@addaleax addaleax mentioned this pull request Mar 8, 2021
Merged
@devsnek devsnek force-pushed the better-native-errors branch from 21b4ee7 to 4434596 Compare March 9, 2021 00:07
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36555/

@devsnek devsnek requested a review from targos March 9, 2021 00:09
@devsnek
Copy link
Member Author

devsnek commented Mar 9, 2021

Is "rebuild" or "retry" the correct button for just doing the failed runners

@targos
Copy link
Member

targos commented Mar 9, 2021

The correct button is "Resume build"

@devsnek
Copy link
Member Author

devsnek commented Mar 9, 2021

Close enough 😄

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36564/

@devsnek
src: add error formatting support
853086f 
PR-URL: nodejs#37598
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@devsnek devsnek force-pushed the better-native-errors branch from 4434596 to 853086f Compare March 9, 2021 16:14
@devsnek devsnek merged commit 853086f into nodejs:master Mar 9, 2021
@devsnek
Copy link
Member Author

devsnek commented Mar 9, 2021

landed in 853086f

@devsnek devsnek deleted the better-native-errors branch March 9, 2021 16:15
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@devsnek @danielleadams
src: add error formatting support
d59c6de 
PR-URL: #37598
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@devsnek @targos
src: add error formatting support
fc0d6e4 
PR-URL: #37598
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@legendecas legendecas mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@devsnek @nodejs-github-bot @targos @jasnell @addaleax @RaisinTen @aduh95