tools: make update-eslint.sh work with npm@7 #37566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
lib / src
lpinca
force-pushed
the
fix/update-eslint-script
branch
2 times, most recently
from
d029772
to
151fbb7
Compare
Trott
approved these changes
Mar 2, 2021
cjihrig
approved these changes
Mar 2, 2021
ruyadorno
reviewed
Mar 3, 2021
ruyadorno
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
👍 LGTM
I would still like to understand better the use case since I believe there's room to make this setup much simpler than it currently is but getting rid of the npm install from a node_modules folder is a big improvement already 😄 thanks @lpinca
lpinca
force-pushed
the
fix/update-eslint-script
branch
from
151fbb7
to
708364d
Compare
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` Fixes: nodejs#37560
lpinca
force-pushed
the
fix/update-eslint-script
branch
from
708364d
to
a6ec31e
Compare
aduh95
approved these changes
Mar 3, 2021
aduh95
added
author ready
lpinca
added a commit
that referenced
this pull request
Mar 4, 2021
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` PR-URL: #37566 Fixes: #37560 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
Landed in aee3ef5. |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` PR-URL: #37566 Fixes: #37560 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` PR-URL: #37566 Fixes: #37560 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` PR-URL: #37566 Fixes: #37560 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` PR-URL: #37566 Fixes: #37560 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Install `eslint-plugin-markdown` at the same level of `eslint` without cd'ing into `eslint` directory, otherwise the following error is raised: ``` npm ERR! code ERESOLVE npm ERR! Cannot destructure property 'name' of 'node' as it is null. ``` PR-URL: #37566 Fixes: #37560 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install
eslint-plugin-markdownat the same level ofeslintwithoutcd'ing into
eslintdirectory, otherwise the following error is raised:Fixes: #37560