Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls #37533

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 27, 2021

The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2021
@nodejs-github-bot
Copy link
Collaborator

The test does not seem to have failed since the issue was first reported
in 2019.

Closes: nodejs#30845

PR-URL: nodejs#37533
Fixes: nodejs#30845
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 1, 2021

Landed in 2748b0a

@Trott Trott merged commit 2748b0a into nodejs:master Mar 1, 2021
@Trott Trott deleted the remove-from-status branch March 1, 2021 20:20
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: nodejs#30845

PR-URL: nodejs#37533
Fixes: nodejs#30845
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 2, 2021
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

PR-URL: #37533
Fixes: #30845
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

PR-URL: #37533
Fixes: #30845
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky test parallel/test-http2-multistream-destroy-on-read-tls
5 participants