Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document the NO_COLOR and FORCE_COLOR env vars #37477

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 22, 2021

Signed-off-by: James M Snell [email protected]
Fixes: #37404

doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/cli.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Feb 22, 2021

These entries need to be duplicated into doc/node.1 so that they show up in the man page.

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @Trott's nits addressed.

doc/api/cli.md Outdated Show resolved Hide resolved
Trott
Trott previously requested changes Feb 23, 2021
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but leaving a "Request changes" until the entries are in doc/node.1 as well. Feel free to dismiss this review once that's happened.

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. labels Feb 23, 2021
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.

doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/cli.md Outdated Show resolved Hide resolved
@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member Author

jasnell commented Feb 26, 2021

Landed in fc6d8f4

@jasnell jasnell closed this Feb 26, 2021
jasnell added a commit that referenced this pull request Feb 26, 2021
Signed-off-by: James M Snell <[email protected]>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Feb 28, 2021
Signed-off-by: James M Snell <[email protected]>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Comment on lines +535 to +536
.Ar 1
,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most mdoc(7) macros allow authors to include trailing punctuation as a separate (final) argument:

.Ar 1 ,

See the "Delimiters" section of mdoc(7) for more info on this feature.

targos pushed a commit that referenced this pull request May 27, 2021
Signed-off-by: James M Snell <[email protected]>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
Signed-off-by: James M Snell <[email protected]>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Signed-off-by: James M Snell <[email protected]>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
Signed-off-by: James M Snell <[email protected]>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please document FORCE_COLOR/NO_COLOR in node -h output
8 participants