doc: document how to register external bindings for snapshot #37463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
marsonya
approved these changes
Feb 22, 2021
jasnell
reviewed
Feb 22, 2021
| } // namespace util | ||
| } // namespace node | ||
|
|
||
| NODE_MODULE_EXTERNAL_REFERENCE(util, node::util::RegisterExternalReferences) |
There was a problem hiding this comment.
Might want to also point out that util needs to be listed in the node_external_reference.h EXTERNAL_REFERENCE_BINDING_LIST_BASE macro
jasnell
approved these changes
Feb 22, 2021
marsonya
requested changes
Feb 24, 2021
Co-authored-by: akhil marsonya <[email protected]>
marsonya
approved these changes
Feb 26, 2021
joyeecheung
added a commit
that referenced
this pull request
Mar 1, 2021
PR-URL: #37463 Refs: #35711 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 7c63bc6 |
lpinca
pushed a commit
to lpinca/node
that referenced
this pull request
Mar 2, 2021
PR-URL: nodejs#37463 Refs: nodejs#35711 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 2, 2021
PR-URL: #37463 Refs: #35711 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 27, 2021
PR-URL: #37463 Refs: #35711 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #37463 Refs: #35711 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #37463 Refs: #35711 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #37463 Refs: #35711 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #35711