Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove FLAKY for test-http2-compat-client-upload-reject #37462

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 20, 2021

As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: #30847

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 20, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: nodejs#30847
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Feb 23, 2021
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: #30847

PR-URL: #37462
Fixes: #30847
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 23, 2021

Landed in 80098e6

@jasnell jasnell closed this Feb 23, 2021
targos pushed a commit that referenced this pull request Feb 28, 2021
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: #30847

PR-URL: #37462
Fixes: #30847
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: #30847

PR-URL: #37462
Fixes: #30847
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
@Trott Trott deleted the test-http2-flaky branch September 25, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky test parallel/test-http2-compat-client-upload-reject
7 participants