Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix alignment of parameters #37422

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

mhdawson
Copy link
Member

fix alignment of parameters in napi_fatal_error

Signed-off-by: Michael Dawson [email protected]

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 18, 2021
@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2021
fix alignment of parameters in napi_fatal_error

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#37422
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95
Copy link
Contributor

aduh95 commented Feb 22, 2021

Landed in f37ae3c

@aduh95 aduh95 merged commit f37ae3c into nodejs:master Feb 22, 2021
targos pushed a commit that referenced this pull request Feb 28, 2021
fix alignment of parameters in napi_fatal_error

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #37422
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
fix alignment of parameters in napi_fatal_error

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #37422
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants