-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix alignment of parameters #37422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Feb 18, 2021
Trott
approved these changes
Feb 18, 2021
Lxxyx
approved these changes
Feb 18, 2021
marsonya
approved these changes
Feb 18, 2021
Lxxyx
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 18, 2021
RaisinTen
approved these changes
Feb 18, 2021
lpinca
approved these changes
Feb 18, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#37422 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
force-pushed
the
fixformatting
branch
from
February 22, 2021 11:29
fd9e0c9
to
f37ae3c
Compare
Landed in f37ae3c |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <[email protected]> PR-URL: #37422 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <[email protected]> PR-URL: #37422 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix alignment of parameters in napi_fatal_error
Signed-off-by: Michael Dawson [email protected]