Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify that async_hook callbacks cannot be async #37384

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 15, 2021

Clarify that the init/before/after/destroy callbacks in async_hooks cannot be async functions.

Signed-off-by: James M Snell [email protected]

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Feb 15, 2021
@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2021
Lxxyx pushed a commit that referenced this pull request Feb 18, 2021
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37384
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@Lxxyx
Copy link
Member

Lxxyx commented Feb 18, 2021

Landed in 85cb9c6b5896

@Lxxyx Lxxyx closed this Feb 18, 2021
@targos
Copy link
Member

targos commented Feb 18, 2021

Actually landed in bb35b6e

@targos targos reopened this Feb 18, 2021
@targos targos closed this Feb 18, 2021
@Lxxyx
Copy link
Member

Lxxyx commented Feb 18, 2021

Actually landed in bb35b6e

Whoops, I forgot I manually changed the commit message, thanks for the reminder

targos pushed a commit that referenced this pull request Feb 28, 2021
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37384
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37384
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants