Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add support for meta info in JS snippet linting #37311

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 10, 2021

Refs: #37162
Refs: eslint/markdown#172

//cc @nodejs/linting

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Feb 10, 2021
tools/update-eslint.sh Outdated Show resolved Hide resolved
aduh95 added a commit to aduh95/remark-preset-lint-node that referenced this pull request Feb 23, 2021
aduh95 added a commit to aduh95/remark-preset-lint-node that referenced this pull request Feb 23, 2021
@jasnell
Copy link
Member

jasnell commented Feb 23, 2021

This needs a rebase.

Trott pushed a commit to nodejs/remark-preset-lint-node that referenced this pull request Mar 4, 2021
@aduh95 aduh95 force-pushed the better-lint-js-in-md branch from 3cc74f8 to 93c4095 Compare March 4, 2021 20:46
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 4, 2021

@nodejs/linting Can you please review 93c4095? 433badd is part of #37604.

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Mar 4, 2021
@Trott
Copy link
Member

Trott commented Mar 4, 2021

I think fs.md needs to be updated (based on the linting results)?

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 4, 2021

I think fs.md needs to be updated (based on the linting results)?

Good catch. That's done in #37605.

@aduh95 aduh95 force-pushed the better-lint-js-in-md branch from 93c4095 to a95ef66 Compare March 4, 2021 21:54
@aduh95 aduh95 force-pushed the better-lint-js-in-md branch from 0d2b5aa to 0afc8ac Compare March 6, 2021 15:06
@aduh95 aduh95 merged commit 0afc8ac into nodejs:master Mar 6, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 6, 2021

Landed in 0afc8ac

@aduh95 aduh95 deleted the better-lint-js-in-md branch March 6, 2021 15:08
targos pushed a commit that referenced this pull request May 30, 2021
targos pushed a commit that referenced this pull request Jun 5, 2021
targos pushed a commit that referenced this pull request Jun 5, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
Marlyfleitas added a commit to Marlyfleitas/Node-remark-preset-lint that referenced this pull request Aug 26, 2022
patrickm68 added a commit to patrickm68/Node-preset-lint that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants