doc: optimize HTML rendering #37301
doc: optimize HTML rendering #37301
Conversation
nodejs-github-bot
added
doc
|
Should we use this syntax instead? I'm suggesting this based on the other functions in the file. |
aduh95
added
the
author ready
Defer rendering sections of docs until they are displayed on the user's screen. PR-URL: nodejs#37301 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
force-pushed
the
doc-content-visibility
branch
from
d226aca
to
0177d4c
Compare
|
Landed in 0177d4c |
|
This change landed despite a failing Jenkins CI and now Jenkins is broken. This change breaks test/doctool/test-doctool-html.js. |
|
The fix appears to be just adding |
|
@Trott On it. |
|
Isn't it weird the test failure is reported on for Windows CI? |
I guess we're only running doctool there? I don't know, that is surprising. |
Attempt to fix that in #37398. |
Refs: nodejs#37301 PR-URL: nodejs#37397 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Defer rendering sections of docs until they are displayed on the user's screen. PR-URL: #37301 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #37301 PR-URL: #37397 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
|
How were the 5000px calculated? (for intrinsic-size) |
It wasn't calculated, it's just a random value which is supposed to be greater than the user screen height.
Nothing – until the user scrolls near the supposed element position, and the browser will have to render the actual content. The only (I think) visible consequence is the scroll bar doing some weird jumps when scrolling (and the much improved render time of course). You can already check how it performs by visiting https://nodejs.org/api/all.html. |
Defer rendering sections of docs until they are displayed on the user's screen. PR-URL: #37301 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #37301 PR-URL: #37397 Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This pr fixes the jittery scrolling behavior introduced in nodejs#37301 fix:nodejs#40099 refs:https://infrequently.org/2020/12/resize-resilient-deferred-rendering/
Defer rendering sections of docs until they are displayed on the user's screen.
Rendering+painting time of
all.htmlon master is~1minon my machine:Rendering+painting time of
all.htmlon this branch is~1son my machine:This feature is only available for Chromium browsers using version 85+ (https://caniuse.com/?search=content%20visibility), and won't change much for other browsers.