Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick beebee4f80ff #37293

Closed
wants to merge 2 commits into from
Closed

deps: V8: cherry-pick beebee4f80ff #37293

wants to merge 2 commits into from

Conversation

santigimeno
Copy link
Member

It contains the following commits:

deps: V8: cherry-pick beebee4f80ff

Original commit message:

cpu-profiler: Use Handle version of SourcePositionTableIterator

The surrounding code can trigger an allocation through InliningStack
which can eventually end up allocating a line ends array.
    
This is fine as-is because the existing iterator code makes a copy
of the byte array. It just triggers the no_gc dcheck in debug mode.

Fixed: v8:10778
Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
Auto-Submit: Peter Marshall <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69247}

Refs: v8/v8@beebee4

test: add cpu-profiler-crash test

This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

@santigimeno santigimeno self-assigned this Feb 9, 2021
@nodejs-github-bot nodejs-github-bot added v14.x v8 engine Issues and PRs related to the V8 dependency. labels Feb 9, 2021
@richardlau
Copy link
Member

Can you target the staging branch (v14.x-staging)? Does this also apply to 15.x/master?

@santigimeno santigimeno changed the base branch from v14.x to v14.x-staging February 9, 2021 16:26
@santigimeno
Copy link
Member Author

santigimeno commented Feb 9, 2021 •
edited
Loading

Can you target the staging branch (v14.x-staging)?

Done

Does this also apply to 15.x/master?

No, the fix is already there though it would be great if it could be applied to 12.x at some point.

Thanks!

@richardlau

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
gengjiawen
gengjiawen requested changes Feb 20, 2021
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forget update common.gypi in first commit.

@santigimeno
Copy link
Member Author

@gengjiawen thanks for pointing that out! Just updated the PR.

@juanarbol
Copy link
Member

I could work on the v12.x backport

psmarshall and others added 2 commits March 1, 2021 10:42
@psmarshall @santigimeno
deps: V8: cherry-pick beebee4f80ff
78af1d4 
Original commit message:
```
cpu-profiler: Use Handle version of SourcePositionTableIterator

The surrounding code can trigger an allocation through InliningStack
which can eventually end up allocating a line ends array.

This is fine as-is because the existing iterator code makes a copy
of the byte array. It just triggers the no_gc dcheck in debug mode.

Fixed: v8:10778
Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
Auto-Submit: Peter Marshall <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69247}
```

Refs: v8/v8@beebee4
@santigimeno
test: add cpu-profiler-crash test
7908e99 
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4
@santigimeno santigimeno force-pushed the santi/backport_v8_10778_bugfix branch from f582bd8 to 7908e99 Compare March 1, 2021 09:42
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 1, 2021 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36421/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3812/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36439/

richardlau pushed a commit that referenced this pull request Mar 2, 2021
@psmarshall @richardlau
deps: V8: cherry-pick beebee4f80ff
15ed780 
Original commit message:
```
cpu-profiler: Use Handle version of SourcePositionTableIterator

The surrounding code can trigger an allocation through InliningStack
which can eventually end up allocating a line ends array.

This is fine as-is because the existing iterator code makes a copy
of the byte array. It just triggers the no_gc dcheck in debug mode.

Fixed: v8:10778
Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
Auto-Submit: Peter Marshall <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69247}
```

Refs: v8/v8@beebee4

PR-URL: #37293
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 2, 2021
@santigimeno @richardlau
test: add cpu-profiler-crash test
69057eb 
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

PR-URL: #37293
Refs: v8/v8@beebee4
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau
Copy link
Member

Landed in 292dffe...69057eb.

@richardlau richardlau closed this Mar 2, 2021
@santigimeno santigimeno deleted the santi/backport_v8_10778_bugfix branch March 2, 2021 17:23
juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 2, 2021
@psmarshall @juanarbol
deps: V8: cherry-pick beebee4f80ff
9724543 
Original commit message:
```
cpu-profiler: Use Handle version of SourcePositionTableIterator

The surrounding code can trigger an allocation through InliningStack
which can eventually end up allocating a line ends array.

This is fine as-is because the existing iterator code makes a copy
of the byte array. It just triggers the no_gc dcheck in debug mode.

Fixed: v8:10778
Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
Auto-Submit: Peter Marshall <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69247}
```

Refs: v8/v8@beebee4

PR-URL: nodejs#37293
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 2, 2021
@santigimeno @juanarbol
test: add cpu-profiler-crash test
cf94304 
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

PR-URL: nodejs#37293
Refs: v8/v8@beebee4
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 2, 2021
@psmarshall @juanarbol
deps: V8: cherry-pick beebee4f80ff
8d3fc8d 
Original commit message:
```
cpu-profiler: Use Handle version of SourcePositionTableIterator

The surrounding code can trigger an allocation through InliningStack
which can eventually end up allocating a line ends array.

This is fine as-is because the existing iterator code makes a copy
of the byte array. It just triggers the no_gc dcheck in debug mode.

Fixed: v8:10778
Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
Auto-Submit: Peter Marshall <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69247}
```

Refs: v8/v8@beebee4

PR-URL: nodejs#37293
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 2, 2021
@santigimeno @juanarbol
test: add cpu-profiler-crash test
a6eae67 
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

PR-URL: nodejs#37293
Refs: v8/v8@beebee4
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@juanarbol juanarbol mentioned this pull request Mar 2, 2021
Closed
richardlau pushed a commit that referenced this pull request Mar 16, 2021
@psmarshall @richardlau
deps: V8: cherry-pick beebee4f80ff
dfa04d9 
Original commit message:
```
cpu-profiler: Use Handle version of SourcePositionTableIterator

The surrounding code can trigger an allocation through InliningStack
which can eventually end up allocating a line ends array.

This is fine as-is because the existing iterator code makes a copy
of the byte array. It just triggers the no_gc dcheck in debug mode.

Fixed: v8:10778
Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
Auto-Submit: Peter Marshall <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69247}
```

Refs: v8/v8@beebee4

PR-URL: #37293
Backport-PR-URL: #37578
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 16, 2021
@santigimeno @richardlau
test: add cpu-profiler-crash test
0f6d445 
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

PR-URL: #37293
Backport-PR-URL: #37578
Refs: v8/v8@beebee4
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@richardlau richardlau mentioned this pull request Mar 18, 2021
Merged
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
@psmarshall @MylesBorins
deps: V8: cherry-pick beebee4f80ff
e446d82 
Original commit message:
```
cpu-profiler: Use Handle version of SourcePositionTableIterator

The surrounding code can trigger an allocation through InliningStack
which can eventually end up allocating a line ends array.

This is fine as-is because the existing iterator code makes a copy
of the byte array. It just triggers the no_gc dcheck in debug mode.

Fixed: v8:10778
Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
Auto-Submit: Peter Marshall <[email protected]>
Commit-Queue: Tobias Tebbi <[email protected]>
Reviewed-by: Tobias Tebbi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69247}
```

Refs: v8/v8@beebee4

PR-URL: #37293
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
@santigimeno @MylesBorins
test: add cpu-profiler-crash test
89046d7 
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

PR-URL: #37293
Refs: v8/v8@beebee4
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees

@santigimeno santigimeno

Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@santigimeno @richardlau @nodejs-github-bot @juanarbol @gengjiawen @psmarshall