Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add saghul as a collaborator #3724

Closed
wants to merge 1 commit into from
Closed

doc: add saghul as a collaborator #3724

wants to merge 1 commit into from

Conversation

saghul
Copy link
Member

@saghul saghul commented Nov 9, 2015

Thanks @Fishrock123 and @chrisdickinson for the onboarding! <3

@MylesBorins
Copy link
Contributor

LGTM

@evanlucas
Copy link
Contributor

LGTM :]

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Nov 9, 2015
@Fishrock123
Copy link
Contributor

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Nov 9, 2015

LGTM (and about time!)

@bnoordhuis
Copy link
Member

LGTM. Welcome aboard, Saúl.

@Trott
Copy link
Member

Trott commented Nov 9, 2015

Pile-on totally-redundant gratuitous LGTM

saghul added a commit that referenced this pull request Nov 9, 2015
@saghul
doc: add saghul as a collaborator
64208ef 
PR_URL: #3724
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@saghul
Copy link
Member Author

saghul commented Nov 9, 2015

Thank you all! Landed in 64208ef ❤️

@saghul saghul closed this Nov 9, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 9, 2015
Closed
@jbergstroem
Copy link
Member

welcome! 👍

saghul added a commit that referenced this pull request Nov 10, 2015
@saghul @Fishrock123
doc: add saghul as a collaborator
a05a0b4 
PR_URL: #3724
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
saghul added a commit that referenced this pull request Nov 17, 2015
@saghul
doc: add saghul as a collaborator
5cbfb76 
PR_URL: #3724
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins
Copy link
Contributor

landed in v4.x-staging in 5cbfb76

saghul added a commit that referenced this pull request Dec 4, 2015
@saghul @rvagg
doc: add saghul as a collaborator
1bc89aa 
PR_URL: #3724
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
saghul added a commit that referenced this pull request Dec 17, 2015
@saghul @jasnell
doc: add saghul as a collaborator
4f7c638 
PR_URL: #3724
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
saghul added a commit that referenced this pull request Dec 23, 2015
@saghul @jasnell
doc: add saghul as a collaborator
c855c7f 
PR_URL: #3724
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@saghul @MylesBorins @evanlucas @Fishrock123 @cjihrig @bnoordhuis @Trott @jbergstroem @jasnell