Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in globals.md #37228

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in globals.md #37228

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 4, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 4, 2021
@aduh95
Copy link
Contributor

aduh95 commented Feb 4, 2021

fast-track?

ItzLevvie
ItzLevvie approved these changes Feb 4, 2021
View reviewed changes
Copy link

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasnell
Copy link
Member

jasnell commented Feb 4, 2021

Landed in 3b36320

@jasnell jasnell closed this Feb 4, 2021
jasnell pushed a commit that referenced this pull request Feb 4, 2021
@RaisinTen @jasnell
doc: fix typo in globals.md
3b36320 
PR-URL: #37228
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RaisinTen RaisinTen deleted the doc/fix-typo-in-globals branch February 5, 2021 13:31
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@RaisinTen @danielleadams
doc: fix typo in globals.md
eb08afd 
PR-URL: #37228
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
doc: fix typo in globals.md
2959c65 
PR-URL: #37228
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RaisinTen @aduh95 @jasnell @cjihrig @richardlau @ItzLevvie @Lxxyx @marsonya @nodejs-github-bot