src: simplify calls to BN_bin2bn in prime gen #37169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Feb 1, 2021
This comment has been minimized.
This comment has been minimized.
tniessen
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Feb 3, 2021
tniessen
added a commit
that referenced
this pull request
Feb 3, 2021
PR-URL: #37169 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
tniessen
removed
the
author ready
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37169 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less equivalent to the previous implementation from #36997, with two subtle differences.
addandremoptions are not stored in secure memory (if it is enabled). However, these options are mostly used for DH, in which case these parameters aren't secret. Either way, they are passed from JS through insecure memory (either asBigIntorArrayBuffer), so it does not help much to protect them here. (I suggested storing the prime in secure memory in crypto: add generatePrime/checkPrime #36997, but notaddorrem.)ERR_CRYPTO_OPERATION_FAILED. Previously, it would either throwERR_CRYPTO_OPERATION_FAILEDif memory allocation failed duringBN_secure_new, orERR_INVALID_ARG_VALUEif memory allocation failed duringBN_bin2bn. The latter doesn't make much sense because the failure ofBN_bin2bnis most likely unrelated to the value of the options.