Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix return type of method in string_search.h #37167

Closed

Conversation

RaisinTen
Copy link
Contributor

Vector::forward() is supposed to return a bool.

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Feb 1, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

`Vector::forward()` is supposed to return a `bool`.
@RaisinTen RaisinTen force-pushed the src/fix-type-in-string_search.h branch from 34af3e0 to 053938e Compare February 9, 2021 11:53
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Trott

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

RaisinTen added a commit that referenced this pull request Feb 10, 2021
`Vector::forward()` is supposed to return a `bool`.

PR-URL: #37167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RaisinTen
Copy link
Contributor Author

Landed in e045dda 🎉

@RaisinTen RaisinTen closed this Feb 10, 2021
@RaisinTen RaisinTen deleted the src/fix-type-in-string_search.h branch February 10, 2021 13:28
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
`Vector::forward()` is supposed to return a `bool`.

PR-URL: #37167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
`Vector::forward()` is supposed to return a `bool`.

PR-URL: #37167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants