Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor binding data for deserialization support #37112

Closed
wants to merge 2 commits into from
Closed

src: refactor binding data for deserialization support #37112

wants to merge 2 commits into from

Commits on Feb 5, 2021

  1. src: rename binding_data_name to type_name in BindingData 

    Previously, this was a per-class string constant for BindingData
which is used as keys for identifying these objects in the binding
data map. These are just type names of the BindingData.
This patch renames the variable to type_name so that
we can generalize this constant for other BaseObjects and use
it for debugging and logging the types of other BaseObjects.
    @joyeecheung
    joyeecheung committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e35ea37 View commit details
    Browse the repository at this point in the history

  2. src: refactor v8 binding 

    1. Put the v8 binding data class into a header so we can reuse
  the class definition during deserialization.
2. Put the v8 binding code into node::v8_utils namespace for
  clarity.
3. Move the binding data property initialization into its
  constructor so that we can reuse it during deserialization
4. Reorder the v8 binding initialization so that we don't
  unnecessarily initialize the properties in a loop
    @joyeecheung
    joyeecheung committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    910040d View commit details
    Browse the repository at this point in the history