test: mark flaky tests on IBM i #36986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
|
CI: https://ci.nodejs.org/job/node-test-pull-request/35606/ (✔️) |
cjihrig
approved these changes
Jan 18, 2021
jasnell
approved these changes
Jan 18, 2021
richardlau
added
the
author ready
|
Shouldn't be any reason for this to wait the full time to land. 👍🏻 to fast-track |
Trott
approved these changes
Jan 19, 2021
Trott
pushed a commit
that referenced
this pull request
Jan 19, 2021
PR-URL: #36986 Refs: #34410 Refs: #36925 Refs: #36929 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 863ec7d |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
PR-URL: #36986 Refs: #34410 Refs: #36925 Refs: #36929 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jan 25, 2021
PR-URL: #36986 Refs: #34410 Refs: #36925 Refs: #36929 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36986 Refs: #34410 Refs: #36925 Refs: #36929 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #34410
Refs: #36925
Refs: #36929
Underlying issues still need to be investigated, but this will prevent these
failures from failing the daily builds.
cc @nodejs/platform-ibmi