Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick fe191e8d05cc #36956

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick fe191e8d05cc #36956

wants to merge 1 commit into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 16, 2021

An unexercised optional chain did not count as a missed branch:

Before:

Screen Shot 2021-01-15 at 6 56 21 PM

After:

Screen Shot 2021-01-15 at 6 56 26 PM

Original commit message:

[coverage] optional chaining coverage

Implement coverage tracking for optional chains.

Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Reviewed-by: Gus Caplan <[email protected]>
Reviewed-by: Sigurd Schneider <[email protected]>
Commit-Queue: Benjamin Coe <[email protected]>
Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

@bcoe
deps: V8: cherry-pick fe191e8d05cc
0ca2a89 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jan 16, 2021
@bcoe bcoe added the coverage Issues and PRs related to native coverage support. label Jan 16, 2021
@bcoe bcoe requested a review from Trott January 16, 2021 02:59
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2021 •
edited by bcoe
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35571/ ✅
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3680/ ✅

@bcoe bcoe added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 16, 2021
@bcoe
Copy link
Contributor Author

bcoe commented Jan 16, 2021

@targos @Trott any objection to fast track?

👍 👎

@bcoe bcoe mentioned this pull request Jan 17, 2021
Closed
@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Jan 18, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 18, 2021

Landed in afd911c

@aduh95 aduh95 closed this Jan 18, 2021
aduh95 pushed a commit that referenced this pull request Jan 18, 2021
@bcoe @aduh95
deps: V8: cherry-pick fe191e8d05cc
afd911c 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: #36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@bcoe @ruyadorno
deps: V8: cherry-pick fe191e8d05cc
fdb9812 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: #36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@bcoe @ruyadorno
deps: V8: cherry-pick fe191e8d05cc
ca479b9 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: #36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Jan 25, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
a699ed2 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Feb 7, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
418947b 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Feb 11, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
a035b80 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Feb 11, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
73e0245 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Feb 12, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
635e44f 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Feb 12, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
80bc3c8 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Feb 23, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
94a8cc0 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Feb 24, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
903e8b6 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: nodejs#36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2021
@bcoe @targos
deps: V8: cherry-pick fe191e8d05cc
bb2a98f 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Reviewed-by: Gus Caplan <[email protected]>
    Reviewed-by: Sigurd Schneider <[email protected]>
    Commit-Queue: Benjamin Coe <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

PR-URL: #36956
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented May 25, 2021

This lands cleanly on v14.x-staging but fails to build. It will either have to be backported manually or marked dont-land-on-v14.x instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. coverage Issues and PRs related to native coverage support. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcoe @nodejs-github-bot @aduh95 @targos @Trott