Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix percentile range in perf_hooks.md #36938

Merged

Conversation

RaisinTen
Copy link
Contributor

The value accepted by histogram.percentile may be below 1 too.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Jan 15, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2021
The value accepted by histogram.percentile may be below 1 too.

PR-URL: nodejs#36938
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95 aduh95 force-pushed the doc/fix-percentile-range-in-perf_hooks.md branch from 563bd54 to b003643 Compare January 18, 2021 11:04
@aduh95
Copy link
Contributor

aduh95 commented Jan 18, 2021

Landed in b003643

@aduh95 aduh95 merged commit b003643 into nodejs:master Jan 18, 2021
@RaisinTen RaisinTen deleted the doc/fix-percentile-range-in-perf_hooks.md branch January 18, 2021 11:22
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
The value accepted by histogram.percentile may be below 1 too.

PR-URL: #36938
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
targos pushed a commit that referenced this pull request May 1, 2021
The value accepted by histogram.percentile may be below 1 too.

PR-URL: #36938
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants