test,benchmark: stop requiring URL and URLSearchParams #36927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the URL and URLSearchParams classes are available in the global object, there is no need to require them from 'url'.
nodejs-github-bot
added
benchmark
jasnell
approved these changes
Jan 14, 2021
targos
approved these changes
Jan 14, 2021
RaisinTen
added
the
author ready
|
Landed in 3dce4fb |
jasnell
pushed a commit
that referenced
this pull request
Jan 18, 2021
Since the URL and URLSearchParams classes are available in the global object, there is no need to require them from 'url'. PR-URL: #36927 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
RaisinTen
deleted the
test,benchmark/stop-requiring-URL-and-URLSearchParams
branch
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
Since the URL and URLSearchParams classes are available in the global object, there is no need to require them from 'url'. PR-URL: #36927 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jan 25, 2021
Since the URL and URLSearchParams classes are available in the global object, there is no need to require them from 'url'. PR-URL: #36927 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Since the URL and URLSearchParams classes are available in the global object, there is no need to require them from 'url'. PR-URL: #36927 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the URL and URLSearchParams classes are available in the
global object, there is no need to require them from 'url'.