http: cleanup ClientRequest oncreate #36862
Conversation
|
@nodejs/http |
ronag
force-pushed
the
client-oncreate
branch
from
a81fc7a
to
57f81ed
Compare
|
@dnlup Do you want to try and land this? |
|
The job is pretty long. It's still running. I don't see performance regressions so far, inspecting the job console output. |
PR-URL: #36862 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daniele Belardi <[email protected]>
|
Landed in 963dec3 |
|
@dnlup The http benchmarks take a long time to run, so it's usually a good idea to use the filter option to run a subset of the http benchmarks. In this case, I think using I'll open a draft revert PR so we can see that benchmark. Assuming no significant performance issues, I'll close the draft revert PR. |
@Trott thank you for the explanation. I apologize for the extra work I caused. |
PR-URL: #36862 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daniele Belardi <[email protected]>
No worries at all. I was only letting you know in case this is an area where you plan on doing other similar work and may need to run another |
PR-URL: #36862 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daniele Belardi <[email protected]>
Iterative work towards cleaning up ClientRequest.