Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clearly document buffer's "Uint" aliases #36796

Closed
wants to merge 1 commit into from
Closed

doc: clearly document buffer's "Uint" aliases #36796

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 5, 2021

Fixes: #36751

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jan 5, 2021
@targos targos mentioned this pull request Jan 5, 2021
Closed
1 task
@targos
Copy link
Member Author

targos commented Jan 9, 2021

Landed in e68299a

@targos targos closed this Jan 9, 2021
@targos targos deleted the fix-36751 branch January 9, 2021 10:13
targos added a commit that referenced this pull request Jan 9, 2021
@targos
doc: document buffer's "Uint" aliases clearly
e68299a 
Fixes: #36751

PR-URL: #36796
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@targos @danielleadams
doc: document buffer's "Uint" aliases clearly
7c7180a 
Fixes: #36751

PR-URL: #36796
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos added a commit that referenced this pull request May 1, 2021
@targos
doc: document buffer's "Uint" aliases clearly
cf0fa7f 
Fixes: #36751

PR-URL: #36796
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: Buffer UInt -> Uint aliases are not documented
5 participants
@targos @addaleax @gireeshpunathil @HarshithaKP @nodejs-github-bot