Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify when messageerror is emitted #36780

Closed
wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 4, 2021

Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell [email protected]
/cc @addaleax @naz

Adapting addaleax's explanation from the issue.

Fixes: nodejs#36333
Signed-off-by: James M Snell <[email protected]>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jan 4, 2021
doc/api/worker_threads.md Outdated Show resolved Hide resolved
Co-authored-by: Darshan Sen <[email protected]>
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 6, 2021
@jasnell
Copy link
Member Author

jasnell commented Jan 6, 2021

This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track

@jasnell
Copy link
Member Author

jasnell commented Jan 6, 2021

Landed in 9ac4047

@jasnell jasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36780
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36780
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36780
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: unclear conditions under which Worker's 'messageerror' is emmited
5 participants