doc: clarify when messageerror is emitted #36780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapting addaleax's explanation from the issue. Fixes: nodejs#36333 Signed-off-by: James M Snell <[email protected]>
nodejs-github-bot
added
doc
addaleax
approved these changes
Jan 4, 2021
juanarbol
approved these changes
Jan 5, 2021
RaisinTen
reviewed
Jan 5, 2021
Co-authored-by: Darshan Sen <[email protected]>
jasnell
added
author ready
|
This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track |
|
Landed in 9ac4047 |
jasnell
added a commit
that referenced
this pull request
Jan 6, 2021
Adapting addaleax's explanation from the issue. Fixes: #36333 Signed-off-by: James M Snell <[email protected]> PR-URL: #36780 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Adapting addaleax's explanation from the issue. Fixes: #36333 Signed-off-by: James M Snell <[email protected]> PR-URL: #36780 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Adapting addaleax's explanation from the issue. Fixes: #36333 Signed-off-by: James M Snell <[email protected]> PR-URL: #36780 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting addaleax's explanation from the issue.
Fixes: #36333
Signed-off-by: James M Snell [email protected]
/cc @addaleax @naz