readline: fix behaviour of Interface plugged to a non-terminal output #36774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
readline
cjihrig
approved these changes
Jan 4, 2021
addaleax
approved these changes
Jan 4, 2021
aduh95
added
author ready
Lxxyx
approved these changes
Jan 4, 2021
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Fixes: nodejs#36773 PR-URL: nodejs#36774 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
aduh95
force-pushed
the
setupHistory-non-terminal-repl
branch
from
233432d
to
fffdaeb
Compare
|
Landed in fffdaeb |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Fixes: #36773 PR-URL: #36774 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Fixes: #36773 PR-URL: #36774 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36773
/cc @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes