Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise exit() and run() text in async_hooks.md #36738

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 2, 2021

Edit for brevity and clarity. Use present tense where possible.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jan 2, 2021
@Trott
Copy link
Member Author

Trott commented Jan 5, 2021

@nodejs/documentation

@Trott
Copy link
Member Author

Trott commented Jan 5, 2021

@nodejs/async_hooks

Edit for brevity and clarity. Use present tense where possible.

PR-URL: nodejs#36738
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@Trott Trott merged commit dd14dba into nodejs:master Jan 6, 2021
@Trott
Copy link
Member Author

Trott commented Jan 6, 2021

Landed in dd14dba

@Trott Trott deleted the ah-exit-run branch January 6, 2021 04:51
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Edit for brevity and clarity. Use present tense where possible.

PR-URL: #36738
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Edit for brevity and clarity. Use present tense where possible.

PR-URL: #36738
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants