Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase read file abort coverage #36716

Closed
wants to merge 1 commit into from
Closed

test: increase read file abort coverage #36716

wants to merge 1 commit into from

Conversation

shootermv
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 1, 2021
@shootermv shootermv force-pushed the increase-abort-readfile-test-coverage branch from d347db7 to 5a80156 Compare January 1, 2021 06:43
benjamingr
benjamingr approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would make the comment shorter, thanks for this :)

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
Lxxyx
Lxxyx approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@Lxxyx Lxxyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one nit, you can include a link in the commit message, to let us know which part of the code test coverage has been improved, like this pull request: #36628

@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35777/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35783/

@benjamingr
Copy link
Member

Thanks! 🙏

Landed in 8c3cdce 🚀

@benjamingr benjamingr closed this Jan 27, 2021
benjamingr pushed a commit that referenced this pull request Jan 27, 2021
@shootermv @benjamingr
test: increase read file abort coverage
8c3cdce 
PR-URL: #36716
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Feb 2, 2021
@shootermv @targos
test: increase read file abort coverage
da07eb6 
PR-URL: #36716
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@shootermv @targos
test: increase read file abort coverage
8f580df 
PR-URL: #36716
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shootermv @nodejs-github-bot @benjamingr @jasnell @Trott @Lxxyx