http: set lifo as the default scheduling strategy in Agent.

[mcollina]

In #33278 we have added a scheduling option for our http.Agent to use a LIFO algorithm instead of FIFO. This greatly reduces the amount of ECONNRESET errors due to timeouts, and it's generically a better production experience for our users.

I propose to make this the default.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[mcollina]

@nodejs/tsc can you please review?

[addaleax]

I’d personally also be happy to land this as a semver-minor change.

[mcollina]

I’d personally also be happy to land this as a semver-minor change.

I'm definitely ok with this. Would you backport down to v14?

[mcollina]

cc @delvedor

[delvedor]

100% agree!
It should not be a semver major as the socket handling is transparent to the user :)

[BridgeAR]

LGTM % an update to the scheduling documentation. It is still documented that fifo is the default :).

Changing it as semver-minor sounds good to me as well!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35312/

[github-actions]

Commit Queue failed

- Loading data for nodejs/node/pull/36685
✔  Done loading data for nodejs/node/pull/36685
----------------------------------- PR info ------------------------------------
Title      http: set lifo as the default scheduling strategy in Agent. (#36685)
Author     Matteo Collina  (@mcollina)
Branch     mcollina:default-lifo -> nodejs:master
Labels     baking-for-lts, dont-land-on-v10.x, dont-land-on-v12.x, http, lts-watch-v14.x, semver-minor
Commits    1
 - http: set lifo as the default scheduling strategy in Agent.
Committers 1
 - Matteo Collina 
PR-URL: https://github.com/nodejs/node/pull/36685
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36685
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-01-05T21:15:34Z: https://ci.nodejs.org/job/node-test-pull-request/35312/
- Querying data for job/node-test-pull-request/35312/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Wed, 30 Dec 2020 12:05:49 GMT
   ✔  Approvals: 8
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36685#pullrequestreview-560024151
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36685#pullrequestreview-560024681
   ✔  - Robert Nagy (@ronag): https://github.com/nodejs/node/pull/36685#pullrequestreview-560034670
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36685#pullrequestreview-560059651
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36685#pullrequestreview-560175591
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/36685#pullrequestreview-560418195
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/36685#pullrequestreview-560564331
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36685#pullrequestreview-560647420
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 36685
From https://github.com/nodejs/node
 * branch                  refs/pull/36685/merge -> FETCH_HEAD
✔  Fetched commits as a3fcf24a6c2f..2b8c2f649209
--------------------------------------------------------------------------------
Auto-merging lib/_http_agent.js
Auto-merging doc/api/http.md
[master 83957d65c9] http: set lifo as the default scheduling strategy in Agent.
 Author: Matteo Collina 
 Date: Wed Dec 30 13:02:27 2020 +0100
 3 files changed, 8 insertions(+), 5 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
http: set lifo as the default scheduling strategy in Agent.
PR-URL: #36685

Reviewed-By: Anna Henningsen [email protected]

Reviewed-By: Michaël Zasso [email protected]

Reviewed-By: Robert Nagy [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Daijiro Wachi [email protected]

Reviewed-By: Ruben Bridgewater [email protected]

Reviewed-By: Rich Trott [email protected]
[master 9a83efb9ce] http: set lifo as the default scheduling strategy in Agent.

Author: Matteo Collina [email protected]

Date: Wed Dec 30 13:02:27 2020 +0100

3 files changed, 8 insertions(+), 5 deletions(-)

✖  9a83efb9ce62f0772bf6dfa471dc8a35181adfc3

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

⚠  0:50     Title should be <= 50 columns.            title-length

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✖  0:59     Do not use punctuation at end of title.   title-format
ℹ  Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/464594830

[mcollina]

Landed in 278c91c

[mcollina]

@nodejs/releasers could you add this to the next v14 release?

[targos]

@mcollina I cherry-picked it on v14.x-staging: f70aee0