Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: deprecate require of _stream_*. #36675

Closed
wants to merge 1 commit into from
Closed

stream: deprecate require of _stream_*. #36675

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 29, 2020
@mcollina mcollina added semver-major PRs that contain breaking changes and should be released in the next major version. dont-land-on-v10.x labels Dec 29, 2020
@mcollina mcollina force-pushed the deprecate-single-stream-files branch from c6bbd39 to 6b33528 Compare December 29, 2020 14:26
addaleax
addaleax requested changes Dec 29, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#deprecations

Avoid Runtime Deprecations when an alias or a stub/no-op will suffice. An alias or stub will have lower maintenance costs for end users and Node.js core.

@mcollina
Copy link
Member Author

Closing in favor of #36684.

@mcollina mcollina closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax requested changes

@ronag ronag Awaiting requested review from ronag

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcollina @addaleax @nodejs-github-bot