Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove dead code from internal/http.js #36630

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

Lxxyx
Copy link
Member

@Lxxyx Lxxyx commented Dec 25, 2020

The nowDate function is no longer used, but the code is not removed.
Refs: #32329

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Dec 25, 2020
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2020
PR-URL: nodejs#36630
Refs: nodejs#32329
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott force-pushed the remove-internal-http-deadcode branch from 8cf00b9 to acaa58e Compare December 27, 2020 14:58
@Trott
Copy link
Member

Trott commented Dec 27, 2020

Landed in acaa58e

@Trott Trott merged commit acaa58e into nodejs:master Dec 27, 2020
@Lxxyx Lxxyx deleted the remove-internal-http-deadcode branch December 27, 2020 15:00
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
PR-URL: #36630
Refs: #32329
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 13, 2021
PR-URL: nodejs#36630
Refs: nodejs#32329
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 13, 2021
PR-URL: #36630
Backport-PR-URL: #36890
Refs: #32329
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36630
Refs: #32329
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants