test: increase runInAsyncScope() coverage #36624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
force-pushed
the
run-in-context
branch
from
6c6de82
to
dcc64c6
Compare
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Dec 26, 2020
targos
approved these changes
Dec 26, 2020
|
Landed in 73b8909 |
Trott
force-pushed
the
run-in-context
branch
from
dcc64c6
to
73b8909
Compare
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
We don't appear to have any test coverage for passing the `thisArg` argument to `runInAsyncScope()`. Test coverage stats seem to bear this out. Add a test for it. PR-URL: #36624 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
We don't appear to have any test coverage for passing the `thisArg` argument to `runInAsyncScope()`. Test coverage stats seem to bear this out. Add a test for it. PR-URL: #36624 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't appear to have any test coverage for passing the
thisArgargument to
runInAsyncScope(). Test coverage stats seem to bear thisout. Add a test for it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes