Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use is None consistently in Python #36606

Merged
merged 3 commits into from
Dec 25, 2020
Merged

tools: use is None consistently in Python #36606

merged 3 commits into from
Dec 25, 2020

Commits on Dec 25, 2020

  1. tools: use is None consistently in Python 

    We use `is None` instead of `== None` everywhere (which mostly just
means test.py) except in one place in genv8constants.py. Switch to `is
None` in genv8constants.py. This is slightly more efficient, although I
can't imagine that makes a measurable difference here.

PR-URL: nodejs#36606
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
    @Trott
    Trott committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    36c17e2 View commit details
    Browse the repository at this point in the history

  2. tools: call close() explicitly in genv8constants.py 

    PR-URL: nodejs#36606
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
    @Trott
    Trott committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    18fc50f View commit details
    Browse the repository at this point in the history

  3. tools: correct usage message for genv8constants.py 

    PR-URL: nodejs#36606
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
    @Trott
    Trott committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    e068eec View commit details
    Browse the repository at this point in the history