Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix diagnostics_channel hasSubscribers error #36599

Merged
merged 0 commits into from
Dec 24, 2020
Merged

lib: fix diagnostics_channel hasSubscribers error #36599

merged 0 commits into from
Dec 24, 2020

Conversation

Lxxyx
Copy link
Member

@Lxxyx Lxxyx commented Dec 22, 2020 •
edited
Loading

Related Issues

Fixes: #36598

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@RaisinTen
Copy link
Contributor

node/lib/diagnostics_channel.js

Line 95 in 656ce92

if (ref) channel = ref.get();

Should't this too be ref.deref()?

@Lxxyx
Copy link
Member Author

Lxxyx commented Dec 22, 2020

node/lib/diagnostics_channel.js

Line 95 in 656ce92

if (ref) channel = ref.get();

Should't this too be ref.deref()?

WeakReference is export by internalBinding('util');, not WeakRef.

@Lxxyx Lxxyx force-pushed the fix-diagnostics_channel-error branch from 7429dce to 2294439 Compare December 22, 2020 15:30
aduh95
aduh95 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
For reference, WeakRef is not available through primordials because it can be disable by the V8 flag --no-harmony-weak-refs (although using this flag crashes node, oh well).

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 22, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35047/

@lpinca
Copy link
Member

lpinca commented Dec 22, 2020

I think the subsystem in commit message should be "lib".

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35048/

@Lxxyx
Copy link
Member Author

Lxxyx commented Dec 23, 2020

I think the subsystem in commit message should be "lib".

Thanks for the reply, but I'd like to know why the subsystem is lib but not diagnostics_channel.

@lpinca
Copy link
Member

lpinca commented Dec 23, 2020

My comment is based on previous commits like c6c36c3.

@Lxxyx Lxxyx changed the title diagnostics_channel: fix hasSubscribers error lib: fix diagnostics_channel hasSubscribers error Dec 23, 2020
@Lxxyx Lxxyx force-pushed the fix-diagnostics_channel-error branch from 2294439 to 1390313 Compare December 23, 2020 06:37
@Lxxyx
Copy link
Member Author

Lxxyx commented Dec 23, 2020

My comment is based on previous commits like c6c36c3.

Thanks, the subsystem in commit message and pull request title is lib now.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35052/

@Trott
Copy link
Member

Trott commented Dec 24, 2020

Landed in 2d40e3f

@Trott Trott closed this Dec 24, 2020
@Trott Trott force-pushed the fix-diagnostics_channel-error branch from 1390313 to 2d40e3f Compare December 24, 2020 15:12
@Trott Trott merged commit 2d40e3f into nodejs:master Dec 24, 2020
@Lxxyx Lxxyx deleted the fix-diagnostics_channel-error branch December 24, 2020 15:24
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Lxxyx @danielleadams
lib: fix diagnostics_channel hasSubscribers error
d20235b 
Fixes: #36598

PR-URL: #36599
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Lxxyx @targos
lib: fix diagnostics_channel hasSubscribers error
08b69fb 
Fixes: #36598

PR-URL: #36599
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@Mesteery Mesteery added the diagnostics_channel Issues and PRs related to diagnostics channel label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen left review comments

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diagnostics_channel: hasSubscribers throw TypeError: WeakRefPrototypeGet is not a function on Node 15.4.0
7 participants
@Lxxyx @RaisinTen @nodejs-github-bot @lpinca @Trott @aduh95 @Mesteery