Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] deps: upgrade npm to 6.14.10 #36571

Closed
wants to merge 1 commit into from
Closed

[v14.x] deps: upgrade npm to 6.14.10 #36571

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Dec 18, 2020 •
edited
Loading

6.14.10 (2020-12-18)

DEPENDENCIES

cc @nodejs/releasers @nodejs/lts

@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. v14.x labels Dec 18, 2020
Trott
Trott approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

MylesBorins
MylesBorins approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

fast-track?

@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35005/

@addaleax addaleax changed the title deps: upgrade npm to 6.14.10 [v14.x] deps: upgrade npm to 6.14.10 Dec 19, 2020
mhdawson
mhdawson approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber Stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35029/

richardlau pushed a commit that referenced this pull request Dec 23, 2020
@ruyadorno @richardlau
deps: upgrade npm to 6.14.10
305c0f4 
PR-URL: #36571
Fixes: #36445
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau
Copy link
Member

Landed in 305c0f4.

@richardlau richardlau closed this Dec 23, 2020
richardlau pushed a commit that referenced this pull request Dec 23, 2020
@ruyadorno @richardlau
deps: upgrade npm to 6.14.10
2eacfbe 
PR-URL: #36571
Fixes: #36445
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
richardlau pushed a commit that referenced this pull request Dec 23, 2020
@ruyadorno @richardlau
deps: upgrade npm to 6.14.10
f08d0fe 
PR-URL: #36571
Fixes: #36445
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau
Copy link
Member

Cherry-picked to v12.x-staging (2eacfbe) and v10.x-staging (f08d0fe)

@richardlau richardlau mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiteslack whiteslack whiteslack approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ruyadorno @MylesBorins @nodejs-github-bot @richardlau @Trott @mhdawson @whiteslack