tools: fix release script sign function #36556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
Dec 18, 2020
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
PR-URL: #36556 Refs: #36540 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in 6c25870 |
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
PR-URL: #36556 Refs: #36540 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36556 Refs: #36540 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot one
scpcommand in the previous fix (#36540), this PR is fixing that.@BethGriggs Apologies for breaking your release flow twice in a row, I really hope this time's the last one 🙈
Refs: #36540 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes