Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove unused variable in configure.py #36525

Merged
merged 0 commits into from
Dec 17, 2020
Merged

tools: remove unused variable in configure.py #36525

merged 0 commits into from
Dec 17, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 15, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 15, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34948/

@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Dec 15, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34961/

@Trott Trott closed this Dec 17, 2020
@Trott Trott merged commit 32d58d7 into nodejs:master Dec 17, 2020
@Trott
Copy link
Member Author

Trott commented Dec 17, 2020

Landed in 32d58d7

@Trott Trott deleted the write-config branch December 17, 2020 13:20
targos pushed a commit that referenced this pull request Dec 21, 2020
@Trott @targos
tools: remove unused variable in configure.py
c6700ad 
PR-URL: #36525
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
tools: remove unused variable in configure.py
1f3c129 
PR-URL: #36525
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @targos @aduh95