Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make executable name more general #36489

Closed
wants to merge 1 commit into from
Closed

test: make executable name more general #36489

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

This test was hardcoded against node but as it's the name of the executable this will fail in Electron's case, so make it more general.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 12, 2020
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34921/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2020
codebytere added a commit that referenced this pull request Dec 14, 2020
@codebytere
test: make executable name more general
2cd8350 
PR-URL: #36489
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere
Copy link
Member Author

Landed in 2cd8350

@codebytere codebytere closed this Dec 14, 2020
@codebytere codebytere deleted the make-v8-warn-test-general branch December 14, 2020 04:38
targos pushed a commit that referenced this pull request Dec 21, 2020
@codebytere @targos
test: make executable name more general
f7635fd 
PR-URL: #36489
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@codebytere @targos
test: make executable name more general
dabbd6d 
PR-URL: #36489
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@codebytere codebytere mentioned this pull request Aug 8, 2023
Merged
@codebytere codebytere mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codebytere @nodejs-github-bot @addaleax @targos