Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use more primordials in internal/encoding.js #36480

Closed
wants to merge 1 commit into from
Closed

lib: refactor to use more primordials in internal/encoding.js #36480

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

@RaisinTen RaisinTen commented Dec 11, 2020 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. label Dec 11, 2020
@RaisinTen RaisinTen force-pushed the lib/refactor-to-use-more-primordials-in-internal/encoding.js branch from 33c364d to 36f8579 Compare December 11, 2020 17:23
@RaisinTen RaisinTen marked this pull request as ready for review December 11, 2020 17:24
@Trott
Copy link
Member

Trott commented Dec 13, 2020

Should any benchmarks be run on this before landing? This file gets used in util.js, internal/crypto/webcrypto.js, and internal/bootstrap/node.js.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34926/

@PoojaDurgad PoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 18, 2020
@aduh95
Copy link
Contributor

aduh95 commented Dec 22, 2020

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/790/

@aduh95
Copy link
Contributor

aduh95 commented Dec 26, 2020

Another benchmark CI to be sure there's no regression: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/806/ (queued, will 404 until it starts)

aduh95
aduh95 approved these changes Dec 26, 2020
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No regression found in the benchmark

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 26, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 26, 2020
@github-actions
Copy link
Contributor

Landed in 9df3b76...c4cbdfa

@github-actions github-actions bot closed this Dec 26, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 26, 2020
@RaisinTen @nodejs-github-bot
lib: refactor to use more primordials in internal/encoding.js
c4cbdfa 
PR-URL: #36480
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RaisinTen RaisinTen deleted the lib/refactor-to-use-more-primordials-in-internal/encoding.js branch December 27, 2020 06:39
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@RaisinTen @danielleadams
lib: refactor to use more primordials in internal/encoding.js
6e338da 
PR-URL: #36480
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@RaisinTen @targos
lib: refactor to use more primordials in internal/encoding.js
3638a31 
PR-URL: #36480
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@RaisinTen @targos
lib: refactor to use more primordials in internal/encoding.js
396c553 
PR-URL: #36480
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@RaisinTen @targos
lib: refactor to use more primordials in internal/encoding.js
01a71dd 
PR-URL: #36480
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaisinTen @Trott @nodejs-github-bot @aduh95 @targos @PoojaDurgad