Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add SIGTRAP to test-signal-handler #36368

Closed
wants to merge 1 commit into from
Closed

test: add SIGTRAP to test-signal-handler #36368

wants to merge 1 commit into from

Conversation

AshCripps
Copy link
Member

On apple sillicon I get test failures on test-signal-handler with SIGTRAP so add that to the test for expected failures.
refs: nodejs/build#2474 (comment)

Example build before change: https://ci.nodejs.org/job/node-test-commit-osx-arm/nodes=osx11/17/

And after: https://ci.nodejs.org/job/node-test-commit-osx-arm/nodes=osx11/18/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2020
@AshCripps AshCripps added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34732/

@richardlau richardlau added the macos Issues and PRs related to the macOS platform / OSX. label Dec 3, 2020
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34737/

@AshCripps AshCripps added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34818/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34821/

@AshCripps AshCripps added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

Landed in ca8eb79...a45f622

@github-actions github-actions bot closed this Dec 8, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 8, 2020
@nodejs-github-bot
test: add SIGTRAP to test-signal-handler
a45f622 
PR-URL: #36368
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@AshCripps AshCripps deleted the apple-signal-handler branch December 8, 2020 13:04
targos pushed a commit that referenced this pull request Dec 21, 2020
@targos
test: add SIGTRAP to test-signal-handler
d3d1f33 
PR-URL: #36368
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@targos targos mentioned this pull request Dec 22, 2020
Merged
@a60814billy a60814billy mentioned this pull request Mar 31, 2021
Closed
a60814billy pushed a commit to a60814billy/node that referenced this pull request Apr 2, 2021
@a60814billy
test: add SIGTRAP to test-signal-handler
9045e7c 
PR-URL: nodejs#36368
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
a60814billy pushed a commit to a60814billy/node that referenced this pull request Apr 2, 2021
@a60814billy
test: add SIGTRAP to test-signal-handler
c2d8aef 
PR-URL: nodejs#36368
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@a60814billy a60814billy mentioned this pull request Apr 2, 2021
Closed
targos pushed a commit that referenced this pull request Apr 11, 2021
@targos
test: add SIGTRAP to test-signal-handler
db04ae6 
Backport-PR-URL: #38051
Co-authored-by: BoHong Li <[email protected]>

PR-URL: #36368
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AshCripps @nodejs-github-bot @evanlucas @lpinca @richardlau @targos