Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix child-process-pipe-dataflow #36366

Closed
wants to merge 1 commit into from
Closed

test: fix child-process-pipe-dataflow #36366

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Make sure all the wc process stdout data is received before checking
its validity.

Fixes: #25988

@santigimeno
test: fix child-process-pipe-dataflow
f07cdd2 
Make sure all the `wc` process stdout data is received before checking
its validity.

Fixes: nodejs#25988
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2020
@santigimeno santigimeno mentioned this pull request Dec 3, 2020
Open
@gireeshpunathil
Copy link
Member

thanks @santigimeno - that looks like a very reasonable explanation to this issue.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34800/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34808/

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34823/

@gireeshpunathil gireeshpunathil added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

Landed in 6d3775e...ca8eb79

@github-actions github-actions bot closed this Dec 8, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 8, 2020
@santigimeno @nodejs-github-bot
test: fix child-process-pipe-dataflow
ca8eb79 
Make sure all the `wc` process stdout data is received before checking
its validity.

Fixes: #25988

PR-URL: #36366
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Dec 21, 2020
@santigimeno @targos
test: fix child-process-pipe-dataflow
166aa8a 
Make sure all the `wc` process stdout data is received before checking
its validity.

Fixes: #25988

PR-URL: #36366
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@santigimeno @targos
test: fix child-process-pipe-dataflow
0e821ff 
Make sure all the `wc` process stdout data is received before checking
its validity.

Fixes: #25988

PR-URL: #36366
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
This was referenced Aug 16, 2022
Open
Open
@Dmarch28 Dmarch28 mentioned this pull request Aug 16, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Aug 16, 2022
Open
@kissofire kissofire mentioned this pull request Aug 16, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Aug 17, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 17, 2022
Open
@baby636 baby636 mentioned this pull request Aug 17, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Aug 17, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky: test-child-process-pipe-dataflow
7 participants
@santigimeno @gireeshpunathil @nodejs-github-bot @jasnell @Trott @lpinca @cjihrig