Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use ToLocal in DeserializeProperties #36279

Closed
wants to merge 1 commit into from
Closed

src: use ToLocal in DeserializeProperties #36279

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 26, 2020

This commit uses ToLocal to avoid having to call ToLocalChecked.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: use ToLocal in DeserializeProperties
4434cbb 
This commit uses ToLocal to avoid having to call ToLocalChecked.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 26, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34613/

@danbev
Copy link
Contributor Author

danbev commented Dec 1, 2020

Landed in 2dc6bf0.

@danbev danbev closed this Dec 1, 2020
@danbev danbev deleted the deserialize_properties_tolocal branch December 1, 2020 05:01
danbev added a commit that referenced this pull request Dec 1, 2020
@danbev
src: use ToLocal in DeserializeProperties
2dc6bf0 
This commit uses ToLocal to avoid having to call ToLocalChecked.

PR-URL: #36279
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@danbev @danielleadams
src: use ToLocal in DeserializeProperties
6ebb98a 
This commit uses ToLocal to avoid having to call ToLocalChecked.

PR-URL: #36279
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@danbev @cjihrig
src: use ToLocal in DeserializeProperties
2afbf99 
This commit uses ToLocal to avoid having to call ToLocalChecked.

PR-URL: nodejs#36279
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
@danbev @targos
src: use ToLocal in DeserializeProperties
685ed2c 
This commit uses ToLocal to avoid having to call ToLocalChecked.

PR-URL: #36279
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@watilde watilde watilde approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danbev @nodejs-github-bot @Trott @watilde @richardlau