Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: neuter external nullptr buffers #3624

Closed
wants to merge 1 commit into from
Closed

buffer: neuter external nullptr buffers #3624

wants to merge 1 commit into from

Commits on Nov 2, 2015

  1. buffer: neuter external nullptr buffers 

    Neuter external `nullptr` buffers, otherwise their contents will be
materialized on access, and the buffer instance will be internalized.

This leads to a crash like this:

    v8::ArrayBuffer::Neuter Only externalized ArrayBuffers can be
    neutered

Fix: nodejs#3619
    @indutny
    indutny committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    0eeb375 View commit details
    Browse the repository at this point in the history