Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add arm64 macOS as experimental #36189

Closed
wants to merge 1 commit into from
Closed

doc: add arm64 macOS as experimental #36189

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Reflect the current status of support for building on arm64 (Apple Silicon/M1) based macOS.

Refs: nodejs/build#2474

cc @nodejs/platform-macos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 20, 2020
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. macos Issues and PRs related to the macOS platform / OSX. labels Nov 20, 2020
mcollina
mcollina approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Trott pushed a commit that referenced this pull request Nov 22, 2020
@richardlau @Trott
doc: add arm64 macOS as experimental
62a5626 
PR-URL: #36189
Refs: nodejs/build#2474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 22, 2020

Landed in 62a5626

@Trott Trott closed this Nov 22, 2020
@richardlau richardlau deleted the building branch November 22, 2020 16:16
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@richardlau @codebytere
doc: add arm64 macOS as experimental
0fbade3 
PR-URL: #36189
Refs: nodejs/build#2474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Pranshu Srivastava <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@devnexen devnexen devnexen approved these changes

@AshCripps AshCripps AshCripps approved these changes

@rexagod rexagod rexagod approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@richardlau @Trott @mcollina @jasnell @targos @devnexen @AshCripps @rexagod @nodejs-github-bot