http: check callback type of imcoming timeout #3618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/http |
|
👎 , protection already exists in |
|
@dougwilson Oho I see. Well then should we have this check here https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L93-L97 |
|
Unsure. Was added in PR #3090 , which can help us decide. |
|
Dupe of #3539 |
|
Kind of a dupe, anyway. That other PR covers other cases. |
| @@ -63,8 +63,11 @@ exports.IncomingMessage = IncomingMessage; | |||
|
|
|||
|
|
|||
| IncomingMessage.prototype.setTimeout = function(msecs, callback) { | |||
| if (callback) | |||
| if (callback) { | |||
| if (typeof callback != 'function') | |||
There was a problem hiding this comment.
Preferred, yes. Although, typeof only ever returns strings.
Fishrock123
pushed a commit
that referenced
this pull request
Nov 5, 2015
- This check is already covered in EventEmitter#addListener() Refs: #3618 PR-URL: #3631 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Replacement landed in 8625a38 |
rvagg
pushed a commit
that referenced
this pull request
Nov 7, 2015
- This check is already covered in EventEmitter#addListener() Refs: #3618 PR-URL: #3631 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.