Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix invalid link in worker_threads.md #36109

Merged
merged 1 commit into from
Nov 15, 2020
Merged

doc: fix invalid link in worker_threads.md #36109

merged 1 commit into from
Nov 15, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 13, 2020

Inadvertent double hash in link makes it invalid and no longer pointing
to the document it intends to point to.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Nov 13, 2020
richardlau
richardlau approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to catch this with the link checker?

@Trott
Copy link
Member Author

Trott commented Nov 13, 2020 •
edited
Loading

Is it possible to catch this with the link checker?

There may be edge cases, but I believe for any link we'd care about, more than one # character would be an error. So we should be able to flag it. For that matter, running this URL through new URL() would throw an error, so maybe that's a simple check we could add.

@Trott
doc: fix invalid link in worker_threads.md
52666aa 
Inadvertent double hash in link makes it invalid and no longer pointing
to the documentation section it intends to point to.

PR-URL: nodejs#36109
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 15, 2020

Landed in 52666aa

@Trott Trott merged commit 52666aa into nodejs:master Nov 15, 2020
@Trott Trott deleted the invalid-link branch November 15, 2020 14:21
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@Trott @codebytere
doc: fix invalid link in worker_threads.md
e8a8513 
Inadvertent double hash in link makes it invalid and no longer pointing
to the documentation section it intends to point to.

PR-URL: #36109
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: fix invalid link in worker_threads.md
2d64947 
Inadvertent double hash in link makes it invalid and no longer pointing
to the documentation section it intends to point to.

PR-URL: #36109
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@watilde watilde watilde approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@aduh95 aduh95 aduh95 approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @lpinca @watilde @richardlau @gireeshpunathil @aduh95 @ZYSzys @nodejs-github-bot