Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: disabled manual construction AbortSignal #36094

Closed
wants to merge 1 commit into from
Closed

events: disabled manual construction AbortSignal #36094

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

@RaisinTen RaisinTen commented Nov 12, 2020 •
edited
Loading

Fixes: #36064

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@RaisinTen RaisinTen force-pushed the stop-manual-construction-AbortController branch 2 times, most recently from 61e66b6 to d6a9e3e Compare November 12, 2020 14:35
@RaisinTen RaisinTen force-pushed the stop-manual-construction-AbortController branch 3 times, most recently from d353925 to 99dd10b Compare November 13, 2020 17:12
@RaisinTen RaisinTen marked this pull request as ready for review November 13, 2020 18:19
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34384/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34385/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2020
aduh95
aduh95 reviewed Nov 13, 2020
View reviewed changes
lib/internal/abort_controller.js
@@ -35,6 +37,11 @@ function customInspect(self, obj, depth, options) {
}

class AbortSignal extends EventTarget {
constructor() {
// eslint-disable-next-line no-restricted-syntax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this comment needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this comment needed?

It's because of this:

node/lib/.eslintrc.yaml

Lines 22 to 23 in c7d2a45

- selector: "NewExpression[callee.name=/Error$/]:not([callee.name=/^(AssertionError|NghttpError)$/])"
message: "Use an error exported by the internal/errors module."
.

@RaisinTen RaisinTen force-pushed the stop-manual-construction-AbortController branch from 99dd10b to ef80268 Compare November 14, 2020 05:22
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 14, 2020 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34390/✅

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 14, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 14, 2020
@github-actions
Copy link
Contributor

Landed in 1d02a35...22293ea

@github-actions github-actions bot closed this Nov 14, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 14, 2020
@RaisinTen @nodejs-github-bot
events: disabled manual construction AbortSignal
22293ea 
Fixes: #36064

PR-URL: #36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RaisinTen RaisinTen deleted the stop-manual-construction-AbortController branch November 14, 2020 14:53
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@RaisinTen @codebytere
events: disabled manual construction AbortSignal
1550073 
Fixes: #36064

PR-URL: #36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
6ffedb9 
Fixes: nodejs#36064

PR-URL: nodejs#36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
25ec596 
Fixes: nodejs#36064

PR-URL: nodejs#36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
0131586 
Fixes: nodejs#36064

PR-URL: nodejs#36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
64cd54b 
Fixes: #36064

PR-URL: #36094
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos added backported-to-v14.x events Issues and PRs related to the events subsystem / EventEmitter. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@himself65 himself65 himself65 approved these changes

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It should be impossible to construct an AbortSignal manually
10 participants
@RaisinTen @nodejs-github-bot @jasnell @Trott @benjamingr @lpinca @himself65 @aduh95 @puzpuzpuz @targos